Skip to content

👷 Use RUM Profiling Schema from RUM-Events-Format #4080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BeltranBulbarellaDD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

👷 Use RUM Profiling Schema from RUM-Events-Format #4080

BeltranBulbarellaDD wants to merge 1 commit into from

Conversation

@BeltranBulbarellaDD
Copy link
Contributor

@BeltranBulbarellaDD BeltranBulbarellaDD commented Jan 13, 2026 •
edited
Loading

Motivation

After merging this we can now use those types in the SDK.
This PR updates Rum-Events-Format and consumes the types.

Changes

Updated Rum-Events-Format and sync.
Changed imports and names for types.
Deleted types we won't need anymore.

Test instructions

To test I run the performance profiling tests by modifying this file and changed:
SDK_BUNDLE_URL to /sdk/datadog-rum.js
and changed this
to:

const sdkBundlePath = path.resolve(import.meta.dirname, '../../packages/rum/bundle')
app.use(profilingMiddleware)
app.use('/sdk', express.static(sdkBundlePath))
app.use(express.static(distPath))

This way I run the profiling tests and get profiles. Link and Link

Also tested on Staging.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jan 13, 2026 •
edited
Loading

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.35 KiB 164.35 KiB 0 B 0.00% ✅
Rum Profiler 4.33 KiB 4.31 KiB -14 B -0.32% ✅
Rum Recorder 20.04 KiB 20.04 KiB 0 B 0.00% ✅
Logs 56.14 KiB 56.14 KiB 0 B 0.00% ✅
Flagging 944 B 944 B 0 B 0.00% ✅
Rum Slim 121.57 KiB 121.57 KiB 0 B 0.00% ✅
Worker 23.63 KiB 23.63 KiB 0 B 0.00% ✅
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0048 0.0054 +12.50%
RUM - add action 0.0146 0.0129 -11.64%
RUM - add error 0.0134 0.0154 +14.93%
RUM - add timing 0.0031 0.0028 -9.68%
RUM - start view 0.0036 0.0034 -5.56%
RUM - start/stop session replay recording 0.0008 0.0008 0.00%
Logs - log message 0.0151 0.0162 +7.28%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 26.64 KiB 25.28 KiB -1.35 KiB
RUM - add action 50.13 KiB 48.22 KiB -1.91 KiB
RUM - add timing 26.76 KiB 26.28 KiB -489 B
RUM - add error 56.21 KiB 54.35 KiB -1.85 KiB
RUM - start/stop session replay recording 25.57 KiB 24.89 KiB -695 B
RUM - start view 424.67 KiB 422.96 KiB -1.71 KiB
Logs - log message 47.45 KiB 45.44 KiB -2.01 KiB

🔗 RealWorld

@datadog-official
Copy link

datadog-official bot commented Jan 13, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
• Patch Coverage: 100.00%
• Overall Coverage: 77.31% (+0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b5feb14 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@BeltranBulbarellaDD BeltranBulbarellaDD mentioned this pull request Jan 13, 2026
Closed
4 tasks
@BeltranBulbarellaDD
Copy link
Contributor Author

BeltranBulbarellaDD commented Jan 13, 2026

Going to put it on staging and monitor if we are receiving correct Profiles

@BeltranBulbarellaDD
Copy link
Contributor Author

BeltranBulbarellaDD commented Jan 14, 2026

/to-staging

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 14, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-14 13:03:47 UTC ℹ️ Start processing command /to-staging

2026-01-14 13:03:54 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 16m (p90)

Commit b5feb148e3 will soon be integrated into staging-03.

2026-01-14 13:16:47 UTC ℹ️ Branch Integration: this commit was successfully integrated

Commit b5feb148e3 has been merged into staging-03 in merge commit da06b69ca7.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-03

dd-mergequeue bot added a commit that referenced this pull request Jan 14, 2026
@dd-mergequeue @BeltranBulbarellaDD
Integrate add_profile_model_from_R-E-F (#4080) into staging-03
da06b69 
Integrated commit sha: b5feb14

Co-authored-by: BeltranBulbarellaDD <[email protected]>
@BeltranBulbarellaDD BeltranBulbarellaDD marked this pull request as ready for review January 15, 2026 10:29
@BeltranBulbarellaDD BeltranBulbarellaDD requested a review from a team as a code owner January 15, 2026 10:29
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Jan 15, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5feb148e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BeltranBulbarellaDD BeltranBulbarellaDD changed the title Replace RUM Profiling Schema 👷 Use RUM Profiling Schema from RUM-Events-Format Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

Assignees

No one assigned

Labels

staging-03

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BeltranBulbarellaDD @BenoitZugmeyer